in planners
--
commit "ae2c090e7167547 [GTP] Unknown TOASTER objects handling"
The message is not comprehensive enough, it should explain more whats going on and what may occur.
On the same line, you forgot the semicolon at the end of line, I don't get why it even compiles...
commit "f70983c888 [GTP] Switching GTP to the logger":
- use more hierarchy (e.g. gtp.tasks.manip.pick.multirrt)
- keep logger naming coherent (I used all lowercase, only alphanumeric char, but this can be discussed)
--
commit "e95351c3a61 [GTP] Adding object positioning function"
void HATPConnection::updateScenario(string rootStr)
rootStr should be named rootPath.
Plus, in that kind of situations, pass a reference! ( const string &rootPath )
--
Commit "6b37fb88 Remove warnings":
- put back localpath attribute in their original order in the class definition.
- keep tabulation consistency in files (e.g. in API/Roadmap/*)
- You removed stuff (e.g. in graph.cpp) but i'm not sure it should be removed. ( if (fct_stop != NULL) : does it compiles in MHP if you remove this ?) [1].
- In kinotrajectory.cpp:135, calling const method and ignoring return value, which is useless. (probably optimized out by the compiler)
- moveTo.cpp : new version is worse than previous.
- pickMultiRrt.cpp :
MANIPULATION_TASK_MESSAGE status = MANIPULATION_TASK_OK;
if (status == MANIPULATION_TASK_OK)
"if" statement is useless
- HRICS_FaceHumans.cpp : come on! How can you change a function(a whole class!!) to dummy just like that. Ok it's WIP, but put at least an error msg, or an abort()... [2]
- ConfGenerator.cpp : see [2]
- MultiHandOverUtils.cpp: It's maybe strictly personal, but I like to avoid using C-style comments (/**/), esp. in functions. (note: it's not personal: https://en.wikibooks.org/wiki/C%2B%2B_Programming/Code/Style_Conventions/Comments)
Morale de ce commit: supprimer les warnings n'est pas une fin en soit.
[1]: maybe its possible to remove the warning without loosing that functionality (if its called like a callback, it's probably because it can be a callback, and hence be NULL). The file where fct_stop and fct_draw are defined is under a compilation flag ( IF (NOT WITH_XFROMS ) in libmove3d/graphic/SourceList.cmake:18 )
[2]: we should discuss how to handle dummy functions in general