Pull request #785
closedChanging fact architecture
Description
Changing the fact architecture to a hierarchical one, based on a singleton calling all the other classes/objects.
the repositories:
/home/magharbi/pull-request/dev/planners
branch: facts
/home/magharbi/pull-request/dev/studio
branch: facts
Updated by Mamoun Gharbi over 8 years ago
- Tracker changed from Bug to Pull request
- Assignee set to Jules Waldhart
Updated by Mamoun Gharbi over 8 years ago
up: forget to put watchers and assignee
Updated by Jules Waldhart over 8 years ago
A few comments about the commit: Changing the facts architecture
- enums shall be put into namespace or class.
- logger names may be shortened (planners.Facts.FactTypeTranslation => planners.facts.translation)
- VirtualFact::Compute() => compute() (lower case) (idem for VirtualProperty and all reimplemented)
- document contents needed for json files for each type (maybe in both code and README* file in data)
- dirname FactsAndProperties => Facts ?
- remove FactManager::getFactTypeFromObject
- FactManager::getClassFromFactType => factFactory ?
- FactTypeTranslation: do you know what you are doing (singleton implementation with reference) (anyway, need to change stuff IMHO)
- comments to remove
- retrieveAndSet*Parameter => fetchParameters
I'm not done yet for this commit, as for the pullrequest.
Updated by Jean-François Erdelyi over 8 years ago
Compile, no segfault and work with SST
+1
Updated by Mamoun Gharbi over 8 years ago
The comments for this and #784 are taken into account in the following repos:
/home/magharbi/pull-request/dev/planners
branch: pullReqMam
/home/magharbi/pull-request/dev/studio
branch: pullReqMam
WARN: the history changed, go to actual master (1933ae10ffcea8374aea2f4adf1e7b294adf1721 - DB move files of EntityTypes into data) to pull
Updated by Jules Waldhart over 8 years ago
refactor: FactManager: computefactFor => computeFactFor
squash 2 last commit together (just before pulling)
the commit "[GTP] bugfix: hatpconnection" introduce 2 cout<<, which should be removed/replaced by M3DLOG messages.
Otherwise seems ok.
Updated by Mamoun Gharbi over 8 years ago
- Status changed from New to Closed
changes done, master updated.
planners|e7cee48d
studio|c2bb61c3