Project

General

Profile

Actions

Pull request #784

closed

Different bugfixes linked to GTP

Added by Mamoun Gharbi over 8 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jules Waldhart

Description

This pull request is mainly about bugfixes concerning GTP:

- hatpconection bugs
- actions bugs
- armId for moveTo

Adding new features to the GTP test function

It only concerns planners:
/home/magharbi/pull-request/dev/planners
branch: bugs

Actions #1

Updated by Mamoun Gharbi over 8 years ago

  • Tracker changed from Bug to Pull request
  • Assignee set to Jules Waldhart
Actions #2

Updated by Mamoun Gharbi over 8 years ago

up: forget to put watchers and assignee

Actions #3

Updated by Jules Waldhart over 8 years ago

  • Status changed from New to Feedback

Have to check the commit "[GTP] new features in test function", in hatpConnection.cpp, updateScenario():

  • the method should take a const Json::Value& (or provide overloads)
  • check what it does when both position and stacks are given in the json.

Alos, refer to CodingRules, and discuss if needed, for the numerous unimplemented methods in geometricTools.
-
conditional +1

Actions #4

Updated by Jean-François Erdelyi over 8 years ago

Compile, no segfault and work with SST

+1

Actions #5

Updated by Théo Ollivier-Triquet over 8 years ago

Checked with Jean-François
+1

Actions #6

Updated by Mamoun Gharbi over 8 years ago

  • the method should take a const Json::Value& (or provide overloads)
    ok
  • check what it does when both position and stacks are given in the json.
    refuse to stack and return an explanation why it is not stacked (placed before)
  • Alos, refer to CodingRules, and discuss if needed, for the numerous unimplemented methods in geometricTools.
    I will put abort() in the functions.
Actions #7

Updated by Mamoun Gharbi over 8 years ago

look at #785

Actions #8

Updated by Mamoun Gharbi over 8 years ago

  • Status changed from Feedback to Closed

Changed done, master updated
planners|2d45eb52

Actions

Also available in: Atom PDF