Pull request #784
closed
Different bugfixes linked to GTP
Added by Mamoun Gharbi over 8 years ago.
Updated over 8 years ago.
Description
This pull request is mainly about bugfixes concerning GTP:
- hatpconection bugs
- actions bugs
- armId for moveTo
Adding new features to the GTP test function
It only concerns planners:
/home/magharbi/pull-request/dev/planners
branch: bugs
- Tracker changed from Bug to Pull request
- Assignee set to Jules Waldhart
up: forget to put watchers and assignee
- Status changed from New to Feedback
Have to check the commit "[GTP] new features in test function", in hatpConnection.cpp, updateScenario():
- the method should take a
const Json::Value& (or provide overloads)
- check what it does when both
position and stacks are given in the json.
Alos, refer to CodingRules, and discuss if needed, for the numerous unimplemented methods in geometricTools.
-
conditional +1
Compile, no segfault and work with SST
+1
Checked with Jean-François
+1
- the method should take a const Json::Value& (or provide overloads)
ok
- check what it does when both position and stacks are given in the json.
refuse to stack and return an explanation why it is not stacked (placed before)
- Alos, refer to CodingRules, and discuss if needed, for the numerous unimplemented methods in geometricTools.
I will put abort() in the functions.
- Status changed from Feedback to Closed
Also available in: Atom
PDF